Add PokemonGo bot version to docker image #4884
Conversation
|
@walkerlee, thanks for your PR! By analyzing the annotation information on this pull request, we identified @th3w4y, @Gobberwart and @alexyaoyang to be potential reviewers |
| && cat /tmp/$BUILD_BRANCH.tar.gz | tar -zxf - --strip-components=1 -C /usr/src/app \ | ||
| && apk del .tar-deps \ | ||
| && rm /tmp/$BUILD_BRANCH.tar.gz | ||
| ADD https://api.github.com/repos/$BUILD_REPO/git/refs/heads/$BUILD_BRANCH /tmp/pgobot-version |
There was a problem hiding this comment.
this is not working if i specify a particular commit as the BUILD_BRANCH
Ex:
https://api.github.com/repos/PokemonGoF/PokemonGo-Bot/git/refs/heads/1862b9bf296e201b1e3b5f2783f6a7436ced5698 404
{
"message": "Not Found",
"documentation_url": "https://developer.github.com/v3"
}
There was a problem hiding this comment.
is there any situation we need to use a commit?
There was a problem hiding this comment.
it order to test new changes... that is why you can also override the BUILD_REPO
In the past there was a COPY . /usr/src/app
the user was able to do it's changes and docker build again
I replaced that with ADD https://github.com/$BUILD_REPO/archive/$BUILD_BRANCH.tar.gz /tmp for various reasons:
- security COPY . means including auth and unfits... and stuff (I know there is a .dockerignore but whatever... )
- being able to reproduce the build if you know create date and LABEL build_branch and build_repo and not support some uncommited local modification that the user might have done...
There was a problem hiding this comment.
ok, so I'll delete this PR
|
I was identified as a reviewer but I don't use docker so pass. |
|
@Gobberwart and now that you commented on this PR the probability to be identified next time increased 🎉 |
|
LOL and now you commented.... OK I think we're done :D |
|
version can always be extrapolated from: docker inspect --format='{{.Created}} {{.ContainerConfig.Labels}}' container_tag_or_id then use the info and get the commit via git-rev-parse Example: |
|
@th3w4y I think this way isn't very precisely |
|
@walkerlee I agree (there could be a few seconds raise condition.. ) but is the only idea i have for now |
|
getting the commit seems to work: https://api.github.com/repos/PokemonGoF/PokemonGo-Bot/commits/dev returns same as since the HEAD of dev at this moment is a388c10 |
|
@th3w4y |
|
LABEL BUILD_COMMIT $(curl -H "Accept: application/vnd.github.VERSION.sha" https://api.github.com/repos/$BUILD_REPO/commits/$BUILD_BRANCH) |
Short Description:
add commit version when create docker image